-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Symfony 7 #1780
Allow Symfony 7 #1780
Conversation
Needs this one first sonata-project/EntityAuditBundle#592 |
@@ -28,6 +28,7 @@ parameters: | |||
doctrine: | |||
dbal: | |||
url: "%env(resolve:DATABASE_URL)%" | |||
use_savepoints: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabled for: dmaicher/doctrine-test-bundle#249
They seem to be required for Doctrine Test Bundle but also enabled by default on DBAL 4 (deprecated not enabling them on DBAL 3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah indeed I did not find any other way to have DBAL 4 compatibility 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lowest build fails with: Doctrine\DBAL\ConnectionException: May not alter the nested transaction with savepoints behavior while a transaction is open.
I am trying to up a bit the DBAL version, but do you know if it is related to something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was more related to doctrine test bundle 7.0 not supporting the use of savepoints (I think), because now the build works using only 8.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can take a look in the next days to get rid of deprecations
Yes, I think most of them are more related to ORM 3.0 than to Symfony 7.0 |
Subject
I am targeting this branch, because this is BC.
Changelog