Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 7 #1780

Merged
merged 9 commits into from
Dec 4, 2023
Merged

Allow Symfony 7 #1780

merged 9 commits into from
Dec 4, 2023

Conversation

jordisala1991
Copy link
Member

Subject

I am targeting this branch, because this is BC.

Changelog

### Added
- Support for Symfony 7.

@jordisala1991
Copy link
Member Author

Needs this one first sonata-project/EntityAuditBundle#592

@jordisala1991 jordisala1991 marked this pull request as draft November 28, 2023 07:00
@@ -28,6 +28,7 @@ parameters:
doctrine:
dbal:
url: "%env(resolve:DATABASE_URL)%"
use_savepoints: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabled for: dmaicher/doctrine-test-bundle#249

They seem to be required for Doctrine Test Bundle but also enabled by default on DBAL 4 (deprecated not enabling them on DBAL 3)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah indeed I did not find any other way to have DBAL 4 compatibility 😕

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowest build fails with: Doctrine\DBAL\ConnectionException: May not alter the nested transaction with savepoints behavior while a transaction is open.

I am trying to up a bit the DBAL version, but do you know if it is related to something else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was more related to doctrine test bundle 7.0 not supporting the use of savepoints (I think), because now the build works using only 8.0

@jordisala1991 jordisala1991 marked this pull request as ready for review December 4, 2023 08:06
@jordisala1991 jordisala1991 requested review from a team and dmaicher December 4, 2023 08:07
Copy link
Contributor

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can take a look in the next days to get rid of deprecations

.github/workflows/test.yaml Show resolved Hide resolved
@jordisala1991
Copy link
Member Author

I can take a look in the next days to get rid of deprecations

Yes, I think most of them are more related to ORM 3.0 than to Symfony 7.0

@jordisala1991 jordisala1991 merged commit b527b97 into 4.x Dec 4, 2023
28 checks passed
@jordisala1991 jordisala1991 deleted the jordisala1991-patch-1 branch December 4, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants